link_mode: Support convert EthtoolLinkModeDuplex to u8

[cathay4t]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cathay4t, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces enhancements to the EthtoolLinkModeDuplex enum by making it Copy and providing a clear conversion path to its u8 representation. This change simplifies the handling of duplex mode values, allowing for more straightforward data manipulation and integration where u8 values are expected.

Highlights

• Enum Trait Update: The EthtoolLinkModeDuplex enum now implements the Copy trait, in addition to Debug, PartialEq, Eq, and Clone.
• Type Conversion: A new impl From<EthtoolLinkModeDuplex> for u8 block has been added, enabling direct conversion of EthtoolLinkModeDuplex enum variants to their corresponding u8 representation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for converting EthtoolLinkModeDuplex to a u8 by implementing the From trait, and also makes the enum Copy for better ergonomics and efficiency. The implementation is correct and idiomatic. My main feedback is to suggest adding unit tests for the new conversion logic to ensure its correctness and prevent any future regressions. Otherwise, the changes look good.

[gemini-code-assist]

This new From implementation is a great addition. To ensure its correctness and prevent future regressions, it would be beneficial to add unit tests for the conversions between EthtoolLinkModeDuplex and u8.

You could add a test module at the end of this file, like so:

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_duplex_conversion() {
        assert_eq!(u8::from(EthtoolLinkModeDuplex::Half), DUPLEX_HALF);
        assert_eq!(u8::from(EthtoolLinkModeDuplex::Full), DUPLEX_FULL);
        assert_eq!(u8::from(EthtoolLinkModeDuplex::Unknown), DUPLEX_UNKNOWN);
        assert_eq!(u8::from(EthtoolLinkModeDuplex::Other(42)), 42);

        assert_eq!(EthtoolLinkModeDuplex::from(DUPLEX_HALF), EthtoolLinkModeDuplex::Half);
        assert_eq!(EthtoolLinkModeDuplex::from(DUPLEX_FULL), EthtoolLinkModeDuplex::Full);
        assert_eq!(EthtoolLinkModeDuplex::from(DUPLEX_UNKNOWN), EthtoolLinkModeDuplex::Unknown);
        assert_eq!(EthtoolLinkModeDuplex::from(42), EthtoolLinkModeDuplex::Other(42));
    }
}