-
Notifications
You must be signed in to change notification settings - Fork 9
Add ability to resolve (and cache) multicast groups for a given family name #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sh3Rm4n
wants to merge
7
commits into
rust-netlink:main
Choose a base branch
from
Sh3Rm4n:feat/multi-cast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7b6af39
Add ability to resolve (and cache) multicast groups for a given family
Ragnt 4890961
Remove tracing logs
Sh3Rm4n 9a9ef71
Fix test
Sh3Rm4n 70a4b52
Use cached group names if filled
Sh3Rm4n 6634458
Reduce left drift in impl
Sh3Rm4n 5e81adf
Fix clippy
Sh3Rm4n 2676788
Fix typo
Sh3Rm4n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this multicast group is also in
GetFamilyreply, I think we should merge this function intoquery_family_id(), so we have single netlink request to get both caches ready.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. But in that case
query_family_ids function signature does not really fit anymore.What about
which returns both
idand the groups. At this point, I should probably introduce a struct instead of the tuple from above.We could still keep
query_family_id(andquery_family_multicast_groups, which would callquery_familyinternally for backwards compatibility. WDTY?