Swap futures dependency for futures-util and futures-channel#35
Open
h7x4 wants to merge 2 commits intorust-netlink:mainfrom
Open
Swap futures dependency for futures-util and futures-channel#35h7x4 wants to merge 2 commits intorust-netlink:mainfrom
futures dependency for futures-util and futures-channel#35h7x4 wants to merge 2 commits intorust-netlink:mainfrom
Conversation
Member
|
@h7x4 The CI is not happy, could you take a look? |
h7x4
force-pushed
the
split-futures-dep
branch
from
202b81d to
367d6fa
Compare
Author
|
The tests seem to be broken on the main branch as well. Bumping |
Author
|
@cathay4t sending a modest ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entirety of
futuresis not used, sofutures-util+futures-channelmight be a better choiceRef rust-netlink/rtnetlink#84
This won't have any effect on binary sizes until rust-netlink/netlink-sys#30 is merged and the
netlink-sysdependency bumped