link: Support changing VLAN filter of bridge itself#144
link: Support changing VLAN filter of bridge itself#144cathay4t merged 1 commit intorust-netlink:mainfrom
Conversation
Summary of ChangesHello @cathay4t, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring VLAN filters on the bridge device itself, which is a useful addition. The implementation is straightforward, adding a bridge_self() method and updating the example to demonstrate its usage. The changes are correct and well-implemented. I have one minor suggestion for the example code to improve its readability and make it more idiomatic.
Mimicking command `bridge vlan add dev br0 vid 11 self` by introducing `LinkBridgeVlan::bridge_self()`. Example code updated and manually tested. Signed-off-by: Gris Ge <fge@redhat.com>
Mimicking command
bridge vlan add dev br0 vid 11 selfby introducingLinkBridgeVlan::bridge_self().Example code updated and manually tested.