Merged
Conversation
RagnarGrootKoerkamp
force-pushed
the
PaddedIt
branch
from
6197918 to
42b7b95
Compare
RagnarGrootKoerkamp
force-pushed
the
PaddedIt
branch
from
42b7b95 to
6c71d24
Compare
RagnarGrootKoerkamp
force-pushed
the
PaddedIt
branch
from
6c71d24 to
b1e27a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@imartayan
Not sure this is very nice to use yet (maybe it's better to just not do this at all?)
I think it should be possible to have some more encapsulation around this, where
PaddedItover au32x8or(u32x8, u32x8)can implement some things that are currently handled downstream, such as collecting into a flat vector for the scalar case.For most other cases I guess the iterator is transformed and the padding is passed on with some modification. Not sure it all that can nicely be captured in some type of some kind that automagically corrects the padding.