Draft
Conversation
9d9636c to
ebb93dc
Compare
ebb93dc to
e5f6c90
Compare
b808d73 to
de9e1f4
Compare
de9e1f4 to
a777802
Compare
added 2 commits
December 5, 2023 17:26
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Allowing a return value for the event closures. This allows for proper error propagation. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
a777802 to
cdb1d6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Allowing a return value for the event closures. This allows for proper error propagation.
Benchmarks
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.