-
Notifications
You must be signed in to change notification settings - Fork 9
Added variant ions and more complex satellite ion definitions to the theoretical model #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…theoretical model
…aset exploratorily
…ses from glycans and immonium ions
|
@di-hardt this PR has hit the stage where so much has changed that I am not sure I dare ask you to review. I am nearing completion, with the last pieces of logic on glycan fragments on peptide fragments still to be written. To give a quick run doen of stuff in here:
Let me know if you are still interested in reviewing. Sorry for making a mess of this PR but all the glycan stuff is really increasing the complexity. |
|
Yeah sorry, I looked over your commits when they came in. Due to the complexity I wanted to do a full review this week. Anyway looked fine to me in the end. |
Variant ions (z/z·/z') are quite common, especially in ETD and UVPD. While researching these I also found that w ions can be formed away from the main z ion backbone cleavage location. So the current model allows those fragments as well.
todo: