Fix Docker container failing to start with /bin/sh Illegal option error#179
Open
04cb wants to merge 1 commit intoruvnet:mainfrom
Open
Fix Docker container failing to start with /bin/sh Illegal option error#17904cb wants to merge 1 commit intoruvnet:mainfrom
04cb wants to merge 1 commit intoruvnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153. The Dockerfile.rust used exec form for CMD (JSON array) with /bin/sh -c ENTRYPOINT, which caused /bin/sh to receive multiple arguments instead of the single command string expected by the -c flag. This resulted in the /bin/sh: 0: Illegal option -- error when running the container with additional arguments like --source esp32.
Changed CMD from exec form to shell form by removing the JSON array brackets, allowing the command to be passed correctly to /bin/sh -c and enabling proper environment variable expansion and argument handling.