Add MS Access as a database option, backticks for object names#21
Open
xavierjefferson wants to merge 2 commits intorvrn22:masterfrom
Open
Add MS Access as a database option, backticks for object names#21xavierjefferson wants to merge 2 commits intorvrn22:masterfrom
xavierjefferson wants to merge 2 commits intorvrn22:masterfrom
Conversation
…umn, constraint, and index names in backticks so that names with spaces or reserved words are handled properly by NHibernate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offer a new Microsoft Access driver option, using the Microsoft.ACE.OLEDB provider in the connection string template.
USER MUST HAVE Microsoft Access Database Engine 2016 Redistributable installed. 32-bit if NMG is running as 32-bit, 64-bit if NMG is running as 64-bit. https://www.microsoft.com/en-us/download/details.aspx?id=54920
In code generation, wrap all string literals for table, column, constraint, and index names in backtick marks (`ObjectNameHere`) so NHibernate processes names with spaces or reserved words properly. Without the backticks, NHibernate would throw exceptions for a column named "INDEX" on some db providers because it's a keyword; or a column named "Customer ID" on likely all DB providers because of the space character.
This latter change is a hold-over from Hibernate (Java)
Reference:
https://groups.google.com/g/nhusers/c/-46QXkkXVV0
https://sdesmedt.wordpress.com/2006/09/04/nhibernate-part-4-mapping-techniques-for-aggregation-one-to-many-mapping/
from Hibernate:
https://stackoverflow.com/questions/50783644/add-backticks-to-column-names-in-hibernate