Security Remediation: SQLi & Broken Access Control in token search #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint performs a search for 'token items' without incorporating any user-specific authorization checks. The
searchService.search()method is called directly with the search text from the path variable, but no authenticated user context (e.g., user ID) is passed to filter results based on ownership or permissions. If 'token items' are intended to be user-specific, this allows an authenticated user to search for and potentially retrieve information about token items belonging to other users, leading to unauthorized data access.Severity: CRITICAL
Type: Broken Access Control
Category: security
Fix Applied: Updated file: src/main/java/hawk/service/SearchSer