feat(exec): enable loading ELF binaries from ext2 filesystem #90
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add load_elf_from_ext2() helper function that loads ELF binaries from
the ext2 filesystem with proper permission checks:
- Resolves path to inode using ext2 driver
- Validates file is not a directory (ENOTDIR)
- Checks execute permission bit S_IXUSR (EACCES)
- Returns file content as Vec<u8>
Modify sys_execv_with_frame() to try ext2 filesystem first:
- For paths containing '/': load directly from ext2
- For bare names: try /bin/<name> on ext2, fall back to test disk
This enables exec("/bin/ls", argv) to load programs from the ext2
filesystem, preparing for full Unix-like program execution. The
test disk fallback ensures backward compatibility during transition.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
load_elf_from_ext2()helper function that loads ELF binaries from the ext2 filesystem with proper permission checkssys_execv_with_frame()to try ext2 filesystem first, with test disk fallback for backward compatibilityChanges
New helper function
load_elf_from_ext2():Modified exec syscall behavior:
/(e.g.,/bin/ls): load directly from ext2 filesystemls): try/bin/<name>on ext2 first, fall back to test diskTest plan
/bindirectory (requires ext2 tools)Next steps (Phase 2b)
🤖 Generated with Claude Code