Refactor parser to use string entry_types
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used the `EntryType` enum to define the possible entry types. This was a little too constrained, as it would fail parsing the `BibTeXEntry`, if the `EntryType` was unknown. So in order to allow for better usability of the tool, such as writing rules for entry types that may be completely uncommon for my personal field, we refactor to use a string `BibTeXEntry.entry_type` from now on. This change needed to be carried out everwhere where `EntryType` was used before, so it turned out to be a significant refactor of the code base. Fixes #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the
EntryTypeenum to define the possible entry types. This was a little too constrained, as it would fail parsing theBibTeXEntry, if theEntryTypewas unknown. So in order to allow for better usability of the tool, such as writing rules for entry types that may be completely uncommon for my personal field, we refactor to use a stringBibTeXEntry.entry_typefrom now on.This change needed to be carried out everwhere where
EntryTypewas used before, so it turned out to be a significant refactor of the code base.Fixes #5