-
Notifications
You must be signed in to change notification settings - Fork 363
Add test for #1000 #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add test for #1000 #1608
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
============================================
+ Coverage 97.23% 97.24% +0.01%
Complexity 2836 2836
============================================
Files 175 175
Lines 9028 8852 -176
============================================
- Hits 8778 8608 -170
+ Misses 250 244 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thank you. could you double check whether this test fails with a sabre/dav version from sept 2017? |
|
Not really, seems SabreDAV 3.2 requires PHP <7.2. |
|
I think this bug may appear only with the CalDAV PDO backend. This test uses |
I added a PDO backend test. Still green. |
| self::assertTrue(in_array('event2', $result)); | ||
| } | ||
|
|
||
| public function testCalendarQueryGH1000() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| public function testCalendarQueryGH1000() | |
| public function testCalendarQueryGH1000(): void |
| protected $setupCalDAV = true; | ||
|
|
||
| protected $caldavCalendars = [ | ||
| [ | ||
| 'id' => 1, | ||
| 'name' => 'Calendar', | ||
| 'principaluri' => 'principals/user1', | ||
| 'uri' => 'calendar1', | ||
| ], | ||
| ]; | ||
|
|
||
| protected $caldavCalendarObjects = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| protected $setupCalDAV = true; | |
| protected $caldavCalendars = [ | |
| [ | |
| 'id' => 1, | |
| 'name' => 'Calendar', | |
| 'principaluri' => 'principals/user1', | |
| 'uri' => 'calendar1', | |
| ], | |
| ]; | |
| protected $caldavCalendarObjects = [ | |
| protected bool $setupCalDAV = true; | |
| protected array $caldavCalendars = [ | |
| [ | |
| 'id' => 1, | |
| 'name' => 'Calendar', | |
| 'principaluri' => 'principals/user1', | |
| 'uri' => 'calendar1', | |
| ], | |
| ]; | |
| protected array $caldavCalendarObjects = [ |
| ], | ||
| ]; | ||
|
|
||
| public function testIssue211() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| public function testIssue211() | |
| public function testIssue211(): void |
Seems the issue is already fixed.