Skip to content

Comments

Created vite-react typescript project#2

Open
austindang67 wants to merge 1 commit intomainfrom
1-create-vite-react-project
Open

Created vite-react typescript project#2
austindang67 wants to merge 1 commit intomainfrom
1-create-vite-react-project

Conversation

@austindang67
Copy link
Collaborator

Created the vite-react typescript project

Created the vite-react typescript project
@austindang67 austindang67 force-pushed the 1-create-vite-react-project branch from e5bab10 to b7be629 Compare September 10, 2025 22:54
@austindang67 austindang67 force-pushed the main branch 2 times, most recently from a45e7a2 to eb731ff Compare September 11, 2025 00:44
@carlosparadis
Copy link
Member

@austindang67

I noticed the last commit was 3 weeks ago! However, I know you have made progress on the code from what you showed. Could you push the more recent version here so I can look at the code architecture?

You may recall I shared with you three resources in regards to both the component design and overall file structure. I would like to review that sooner than later to avoid substantial rework.

@austindang67
Copy link
Collaborator Author

@austindang67

I noticed the last commit was 3 weeks ago! However, I know you have made progress on the code from what you showed. Could you push the more recent version here so I can look at the code architecture?

You may recall I shared with you three resources in regards to both the component design and overall file structure. I would like to review that sooner than later to avoid substantial rework.

Hi Carlos, my code is currently on the branch titled "3-create-landing-page-with-network-graph."

Would you like me to migrate that code into this PR?

Otherwise, would it be fine for me to just merge the current PR we are commenting on into main?

@carlosparadis
Copy link
Member

Ah I see the issue. Please create a new PR (do not close #1 yet ) associated to #3.

Let me review both PRs after you do it, and I will get back to you. As a rule of thumb, let me handle the merges, that way we avoid having to revert them in case there is any miscommunication.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants