fix: increase poll frequency to 1s W-20866289#1499
Merged
iowillhoit merged 2 commits intomainfrom Jan 13, 2026
Merged
Conversation
|
This issue has been linked to a new work item: W-20866289 |
cristiand391
changed the title
iowillhoit
reviewed
Jan 13, 2026
| await deploy.cancel(); | ||
| return deploy.pollStatus({ | ||
| frequency: Duration.milliseconds(500), | ||
| frequency: Duration.seconds(1), |
Contributor
There was a problem hiding this comment.
Took me a minute to figure out why this did not need to be a number... I don't like this overload that takes either a frequency number or options object 😛 Also that the variables are Numbers that are converted to Duration and the option object just takes Duration. I wish we would have taken Duration everywhere.
iowillhoit
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increases polling frequency from 500ms to 1second for:
project retrieve startproject deploy reportproject deploy resumeproject deploy validateproject deploy cancelWhile discussing the changes done in forcedotcom/source-deploy-retrieve#1663 with @iowillhoit we found that
project retrieve startalways hardcodes the poll frequency to 500ms (project deploy startleaves it undefined in code so SDR calculates it based on the component set size).This PR increases the poll frequency for retrieve and other deploy commands, why?
For small deploy/retrieves there's no noticeable difference and for long ones we now save quite a few API calls
other cmd behaviors to keep in mind while reviewing:
project deploy report:This command is used to get the deploy status (without updating source-tracking), when passing in
--waitit does polling.project deploy resumeWe suggest to run this command after async deploys or if
project deploy start --wait <number>fails.What issues does this PR fix or reference?
@W-20866289@