openrc startup script for consul, for Gentoo and Alpine. Optimized install.sls#27
Open
morgana2313 wants to merge 11 commits intosaltstack-formulas:masterfrom
Open
openrc startup script for consul, for Gentoo and Alpine. Optimized install.sls#27morgana2313 wants to merge 11 commits intosaltstack-formulas:masterfrom
morgana2313 wants to merge 11 commits intosaltstack-formulas:masterfrom
Conversation
New startup_params parameter
Add startup params to consul
Add startup params to consul
Startup params for consul
Add openrc startup scripts for Gentoo and Alpine
Add openrc startup script for Gentoo and Alpine
Only download/unzip/install/link consul binary if right version not already installed.
OpenRC startup file
vutny
suggested changes
Dec 27, 2017
Contributor
vutny
left a comment
vutny
left a comment
There was a problem hiding this comment.
Thanks for PR @morgana2313 .
I have couple of suggestions to make it clear:
- Your fork was based on older repo revision, so there are some conflicts need to be resolved. You could rebase against master head.
- It seems you have a duplicate copy of
consul.openrcfile at the repo root, that has not been used anywhere.
Also, would you mind to "squash" some commits which contains temporary changes?
This is good StackOverflow question to start with: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.