feat(servers_config): craft states ids with server to get states easier to extend#297
Open
sticky-note wants to merge 1 commit intosaltstack-formulas:masterfrom
Open
feat(servers_config): craft states ids with server to get states easier to extend#297sticky-note wants to merge 1 commit intosaltstack-formulas:masterfrom
server to get states easier to extend#297sticky-note wants to merge 1 commit intosaltstack-formulas:masterfrom
Conversation
sticky-note
force-pushed
the
feat/ids
branch
from
80f2a15 to
b66b792
Compare
sticky-note
requested review from
aboe76,
javierbertoli,
myii and
noelmcloughlin
sticky-note
force-pushed
the
feat/ids
branch
from
b66b792 to
f580eeb
Compare
instead of `loop.index0` to get states easier to extend
BREAKING CHANGES: All `server_conf_{int}` and `server_state_{int}` will be renamed
to `nginx_{server}_server_config_file` and `nginx_{server}_server_state_symlink`
respectively
sticky-note
force-pushed
the
feat/ids
branch
from
f580eeb to
ed23070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?Yes.
All
server_conf_{int}andserver_state_{int}will be renamed tonginx_{server}_server_config_fileandnginx_{server}_server_state_symlinkrespectivelyRelated issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context