fix(package.install): proper package for CentOS and Rocky Linux 8#4
Open
emansom wants to merge 1 commit intosaltstack-formulas:masterfrom
Open
fix(package.install): proper package for CentOS and Rocky Linux 8#4emansom wants to merge 1 commit intosaltstack-formulas:masterfrom
emansom wants to merge 1 commit intosaltstack-formulas:masterfrom
Conversation
6dc71d5 to
f13db25
Compare
fixes saltstack-formulas#3 Squashed commit of the following: commit f07bf84 Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 19:06:29 2022 +0200 fix(osfingermap): support CentOS 8 commit 7220f67 Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:56:59 2022 +0200 fix(osfingermap): set service name to wg-quick for Rocky Linux 8 commit aeb7ac7 Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:48:57 2022 +0200 fix(package.install): set name to pkgrepo state call commit 311851a Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:44:47 2022 +0200 fix(package.install): indent wireguard-package-install-pkg-{{ pkg_name }} correctly commit 2793a10 Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:41:38 2022 +0200 fix(package.install): resolve conflicting state ID commit 59d9982 Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:40:20 2022 +0200 fix(package.install): iterate over all pkgs instead commit 773e53a Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:37:18 2022 +0200 fix(package.install): support CentOS and Rocky Linux 8 commit 6e0d328 Author: Ewout van Mansom <ewout@vanmansom.name> Date: Fri May 20 18:36:19 2022 +0200 chore(precommit): update
Contributor
|
Thanks for your recent contributions to this formula, @emansom. I'd like to approach this situation a little differently. The CI has never been activated on this formula until after you sent this PR through -- it prompted me to get it set up. I've also spent some time getting the CI fixed for all Linux distros. I'd like to push through those changes first and then discuss rebasing this PR. The difference is that you're proposing the use of I'll let you know when the CI is up and running properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#3
Describe the changes you're proposing
Append CentOS and Rocky Linux 8 package information to the
osfingermap.yamlfile and implement logic to optionally setup repos as dependencies of packages inpackage/install.sls.Pillar / config required to test the proposed changes
/srv/pillar/wireguard.slsDebug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context
Updated
.pre-commit-config.yamlas well from latesttemplate-formula.Resolved
rst-lint"title underline too short" warnings indocs/README.rst.