Conversation
samcday
left a comment
There was a problem hiding this comment.
/oc some feedback to address.
By the way, I asked OpenCode to rework a PR in a separate project yesterday and it failed because after amending the commits it didn't force-push to the PR branch. Might it have worked if I was just explicit about doing the force push?
|
/oc the build is failing. and there's some review feedback for you to address. |
|
Adjusted Next steps:
|
|
/oc can you squash the commits down and force push? |
2f69de0 to
8e7dd74
Compare
|
Squashed the branch to a single commit and force-pushed it.
If you want, I can run tests next. |
|
LGTM. I'll wait a couple of days before I merge, unless someone (human) else gives me a +1 sooner. |








Switched session parsing to use GLib’s
KeyFile, so.desktopentries withoutType=Applicationstill load while keeping localizedNamelookups and the sameExec/DesktopNameshandling. All changes are insrc/sessions.rs.Tests not run (not requested).
Next steps:
cargo testphoc -S -E "cargo test"Closes #149
opencode session | github run