Skip to content

Use GKeyFile for session parsing#153

Merged
samcday merged 1 commit intomainfrom
opencode/issue149-20260130202524
Feb 2, 2026
Merged

Use GKeyFile for session parsing#153
samcday merged 1 commit intomainfrom
opencode/issue149-20260130202524

Conversation

@opencode-agent
Copy link
Contributor

Switched session parsing to use GLib’s KeyFile, so .desktop entries without Type=Application still load while keeping localized Name lookups and the same Exec/DesktopNames handling. All changes are in src/sessions.rs.

Tests not run (not requested).

Next steps:

  1. cargo test
  2. If you want to exercise Wayland-dependent tests: phoc -S -E "cargo test"

Closes #149

New%20session%20-%202026-01-30T20%3A25%3A24.197Z
opencode session  |  github run

@samcday samcday added the ci-ok PR looks safe / author is trusted, run pull_request_target build workflow label Jan 30, 2026
Copy link
Owner

@samcday samcday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/oc some feedback to address.

By the way, I asked OpenCode to rework a PR in a separate project yesterday and it failed because after amending the commits it didn't force-push to the PR branch. Might it have worked if I was just explicit about doing the force push?

@samcday
Copy link
Owner

samcday commented Jan 30, 2026

/oc the build is failing. and there's some review feedback for you to address.

@opencode-agent
Copy link
Contributor Author

Adjusted session_list to use a scoped keyfile_locale_string closure and inlined the KeyFile string lookups at the two callsites, per review feedback. This keeps all parsing logic local to session_list while still handling localized Name and defaulting missing Exec/DesktopNames values. Updated code is in src/sessions.rs.

Next steps:

  1. cargo test
  2. phoc -S -E "cargo test" if you want Wayland-dependent coverage

New%20session%20-%202026-01-30T22%3A28%3A08.978Z
opencode session  |  github run

@samcday
Copy link
Owner

samcday commented Jan 30, 2026

/oc can you squash the commits down and force push?

@opencode-agent opencode-agent bot force-pushed the opencode/issue149-20260130202524 branch from 2f69de0 to 8e7dd74 Compare January 30, 2026 23:18
@opencode-agent
Copy link
Contributor Author

Squashed the branch to a single commit and force-pushed it.

  • New commit: sessions: use GKeyFile parsing
  • Branch updated: opencode/issue149-20260130202524 (forced update)

If you want, I can run tests next.

New%20session%20-%202026-01-30T23%3A17%3A53.163Z
opencode session  |  github run

@samcday
Copy link
Owner

samcday commented Jan 30, 2026

LGTM. I'll wait a couple of days before I merge, unless someone (human) else gives me a +1 sooner.

@samcday samcday added the demo This PR should have demo videos recorded and published. label Jan 30, 2026
@github-actions
Copy link

The CI build recorded and generated some videos

Demo video (shown on README and release notes)

accent-colours

emergency-calls

first-run

simple-flow

trivial-flow

@samcday samcday merged commit d6eba29 into main Feb 2, 2026
8 checks passed
@samcday samcday deleted the opencode/issue149-20260130202524 branch February 2, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-ok PR looks safe / author is trusted, run pull_request_target build workflow demo This PR should have demo videos recorded and published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't start Plasma session from phrog [Type=Application]

1 participant