Adding Brazilian Formatting#45
Open
cristovao-trevisan wants to merge 5 commits intosample-usr:masterfrom
Open
Conversation
…nd changing default isNumberValid function
cristovao-trevisan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding the brazilian phone format. The problem is that the format may change among the states (and cities), including an extra number.
It may look like this:
+55 (..) ....-....Or like this: like this:
+55 (..) .....-....I decided to add another string match for optional numbers, to be set only when all the dots are already fulfilled, and named it "?".
Also I think the length of the input should not be longer than the format specifies (don't know if this is a general case though), so I removed the possibility for the formatted number to outgrow the specification.
I also changed the default validity function to check the format after it the input has been clicked.