Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale derived facts on load_rules
The evaluator only adds facts, never removes them. When rules were reloaded (e.g. after retracting a base fact),
old derived facts would persist. The fix clears all derived predicates before re-evaluating from scratch.
Incorrect incremental maintenance for negation and recursion
The previous incremental derive/retract code was too naive:
"active" derived facts.
(transitive chains break it).
The fix introduces a tiered strategy:
evaluator from base facts)
The tests cover the newly-fixed cases: deep transitive ancestor chains, retraction removing derived facts,
banning/unbanning with negation, and rule reloads clearing stale state.