Skip to content

Conversation

@johnwonkim
Copy link
Contributor

Add Owner field to Task struct.

@coveralls
Copy link

coveralls commented Mar 28, 2025

Pull Request Test Coverage Report for Build 14139577577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.517%

Totals Coverage Status
Change from base Build 13999777223: 0.0%
Covered Lines: 730
Relevant Lines: 1417

💛 - Coveralls

Copy link

@ran-arigur ran-arigur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

task.go Outdated
Comment on lines 16 to 18
// Owner of the task
Owner string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Per https://tip.golang.org/doc/comment, the comment should be a complete sentence, ending with a period:

// Owner is the owner of the task.

It might also be good to explain roughly what we mean by "owner":

// Owner is the owner of the task, such as the name or contact info of the team responsible
// for maintaining it. It is optional.

Add Owner field to Task struct.
@johnwonkim johnwonkim force-pushed the johnkim/add-owner-field-to-task branch from 323391f to 47b043e Compare March 28, 2025 23:22
@johnwonkim johnwonkim merged commit cdce125 into master Mar 28, 2025
1 check passed
@johnwonkim johnwonkim deleted the johnkim/add-owner-field-to-task branch March 28, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants