Add support for Python 3.14 on windows builds#352
Merged
samuelcolvin merged 9 commits intosamuelcolvin:mainfrom Oct 14, 2025
Merged
Add support for Python 3.14 on windows builds#352samuelcolvin merged 9 commits intosamuelcolvin:mainfrom
samuelcolvin merged 9 commits intosamuelcolvin:mainfrom
Conversation
Contributor
Author
|
I thought this is an easy one, but the first pipeline already fails with the windows cp3.13 builds Built wheel for CPython 3.13 to dist\watchfiles-1.1.0-cp313-cp313-win_amd64.whl
Compiling pyo3-build-config v0.25.1
Compiling pyo3-ffi v0.25.1
Compiling pyo3-macros-backend v0.25.1
Compiling pyo3 v0.25.1
error: failed to run custom build command for `pyo3-ffi v0.25.1`https://github.com/samuelcolvin/watchfiles/actions/runs/18474739835/job/52636624027 Because of the |
Contributor
Author
|
At least the last update commit seems to fix the pipeline. Not sure if the other updates should be reverted and taken in another pr? fix taken from PyO3/maturin#2528 |
Owner
|
oh, nice chat. I think we're not good, I've reverted some of the unnecessary things I tried to fix it, if this passes, I think we can make a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing support for Python 3.14 on windows builds
closes #351