Fix #29 - Report error when jump to definition doesn't find var#35
Fix #29 - Report error when jump to definition doesn't find var#35bbuccianti wants to merge 1 commit intosanel:masterfrom
Conversation
7c55def to
b1d838a
Compare
|
With the last force-push I've added the lexical-binding: t as a file variable in order to use a closure in monroe-eval-jump. This work as a medium to have the var and ns we are looking for inside the callback. Please let me know if changes are needed. Thanks! |
b1d838a to
c3f124f
Compare
c3f124f to
31b43bd
Compare
|
I've added the closure for have ns on the calback, but never used it! My mistake. Now I think it's okay. |
|
Thank you for this! Can you just please show me example of what it tries to address? |
|
Sure! On this issue #29 , you've added a sample implementation for a way to being able to jump to function definitions. I've just taked that, and make it work with current state of the project (monroe). Personally, I've never used that feature, but a few tests showed that it's working properly. You just need to make a function and from a invocation you can try monroe-jump and you're there. In the case the function doesn't exist, the nrepl server return a exception and that's when we know that we can't jump to that function (I think). So it shows you with a message which function was looking for and in which namespace. Let me know if this helps! Thanks |
I know it's not the most elegant solution, but it's working.
Let me know if some changes are needed.
Thanks!