Y25-283: Refactoring Limber configuration loading process#2520
Draft
Conversation
3 tasks
…ethods for nested configuration access; add initial settings_spec for pipelines
…ling; add config.yml for testing
…nfiguration values
…r accessing purposes
…m-we-would-like-to-refactor-Limber's-process-for-parsing-its-configuration-files-so-that-we-can-spot-errors-earlier # Conflicts: # app/models/concerns/presenters/creation_behaviour.rb
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2520 +/- ##
========================================
Coverage 84.25% 84.26%
========================================
Files 499 499
Lines 20196 20195 -1
Branches 377 377
========================================
+ Hits 17016 17017 +1
+ Misses 3177 3175 -2
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…m-we-would-like-to-refactor-Limber's-process-for-parsing-its-configuration-files-so-that-we-can-spot-errors-earlier
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version