Y25-598 - scRNA - add tube size options#2645
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2645 +/- ##
===========================================
+ Coverage 84.59% 84.63% +0.03%
===========================================
Files 501 501
Lines 20538 20606 +68
Branches 377 377
===========================================
+ Hits 17374 17439 +65
- Misses 3161 3164 +3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
StephenHulme
left a comment
There was a problem hiding this comment.
Looks good 👍
I'm still not a fan of the numbers and point punctuation in the purpose names, but realise that it might not be a simple change.
…clicked add child on
|
Would you please add more detail to the description? It seems like there is a lot more happening than just a viability threshold change? |
StephenHulme
left a comment
There was a problem hiding this comment.
Glad to see the . removed from the purpose names!
There's a lot going on here and I'm not sure I fully understand everything, but what I do understand seems fine.
One small suggestion, but looks good otherwise.
Thanks for the helpful comments!
app/views/exports/hamilton_lrc_pbmc_defrost_pbs_1ml_to_lrc_pbmc_pools.csv.erb
Show resolved
Hide resolved
StephenHulme
left a comment
There was a problem hiding this comment.
Thanks for the refactoring and extra details in the summary - looks good 🚀
Closes #5389
Changes proposed in this pull request