Skip to content

Y25-598 - scRNA - add tube size options#2645

Open
andrewsparkes wants to merge 23 commits intodevelopfrom
y25-598-scrna-add-tube-size-options
Open

Y25-598 - scRNA - add tube size options#2645
andrewsparkes wants to merge 23 commits intodevelopfrom
y25-598-scrna-add-tube-size-options

Conversation

@andrewsparkes
Copy link
Member

@andrewsparkes andrewsparkes commented Nov 27, 2025

Closes #5389

Changes proposed in this pull request

  • adds new separated pipeline routes starting with 0.8 and 1.0ml input tubes, to accommodate different lab processes for those two types of input
  • defines new tube and plate purposes and pipeline configuration for the new routes
  • adds a new bed verifications for the 1ml tube route and modifies an existing one for the 0.8ml route
  • adds a new Cellaca count file for the 1ml tube route
  • adds a new driver file for the 1ml tube route
  • change to viability threshold value 65 -> 50
  • added a validation in donor_pooling_validator.rb to check you scanned the parent you clicked 'add LRC PBMC Pool plate' on
  • added a filter for export file_links in the donor_pooling_presenter so we don't show download buttons for driver files for parents we don't have
  • added another filter in the donor_pooling_presenter on the bed verification buttons to show only relevant ones

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.63%. Comparing base (1b9b14c) to head (8959d07).

Files with missing lines Patch % Lines
...models/presenters/donor_pooling_plate_presenter.rb 91.89% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2645      +/-   ##
===========================================
+ Coverage    84.59%   84.63%   +0.03%     
===========================================
  Files          501      501              
  Lines        20538    20606      +68     
  Branches       377      377              
===========================================
+ Hits         17374    17439      +65     
- Misses        3161     3164       +3     
  Partials         3        3              
Flag Coverage Δ
javascript 79.71% <ø> (ø)
pull_request 84.62% <95.58%> (+0.03%) ⬆️
push 84.63% <95.58%> (+0.03%) ⬆️
ruby 92.59% <95.58%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewsparkes andrewsparkes linked an issue Dec 1, 2025 that may be closed by this pull request
6 tasks
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I'm still not a fan of the numbers and point punctuation in the purpose names, but realise that it might not be a simple change.

@StephenHulme
Copy link
Contributor

StephenHulme commented Feb 10, 2026

Would you please add more detail to the description? It seems like there is a lot more happening than just a viability threshold change?

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see the . removed from the purpose names!
There's a lot going on here and I'm not sure I fully understand everything, but what I do understand seems fine.
One small suggestion, but looks good otherwise.
Thanks for the helpful comments!

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring and extra details in the summary - looks good 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-598 - Add New Tube and Plate Purposes to scRNA Core Pipeline

2 participants