Y25-715 - creating a balanced pool tube as soon as the first run finishes#2690
Draft
KatyTaylor wants to merge 8 commits intodevelopfrom
Draft
Conversation
…aceholder for where the new logic will go
| next unless allowed_request_state?(v2_tube_req) | ||
| # Collect the wafer IDs for all requests coming out of all downstream sequenced tubes | ||
| wafer_ids = downstream_sequenced_tubes.map do |tube| | ||
| fetch_tube(tube)&.requests_as_source&.map(&:id_wafer_lims) |
Member
There was a problem hiding this comment.
will this filter out any failed / cancelled tubes (those unlikely to have wafers)?
can wafers be failed or cancelled?
Collaborator
Author
There was a problem hiding this comment.
No, but I didn't worry about it because the MLWH will only contain rows for ones that have had runs completed. If we include a couple more ids than needed in the query I don't think it really matters?
yoldas
reviewed
Feb 11, 2026
Member
yoldas
left a comment
yoldas
left a comment
There was a problem hiding this comment.
can’t limber get this information from sequencescape using some endpoint, rather than opening connection to mlwh?
…Handle scenario where there are no wafer_ids. Move method back to not private, for testing
…k mlwh query to test env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2654
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version