Conversation
yoldas
reviewed
Feb 10, 2026
| .required('Region of interest is a required field') | ||
| .label('ROI') | ||
| .max(64, 'Region of interest field should be string of maximum length 64') | ||
| .max(64, 'Region of interest field should be string of maximum length 64'), |
Member
There was a problem hiding this comment.
This could also check the format using matches (accepted characters: A-Z, a-z, 0-9, underscores (_) and hyphen (-)).
yoldas
approved these changes
Feb 10, 2026
| <div className="flex flex-col items-center justify-between space-y-8"> | ||
| <Labware | ||
| labware={lw.labware} | ||
| gridDirection={GridDirection.LeftUp} |
Member
There was a problem hiding this comment.
Why is this rotated 180 degrees, i.e. A1 is bottom-right?
Contributor
Author
There was a problem hiding this comment.
this is to match the previous behaviour, matching the labware slots direction in the lab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes x1490