feat(s3_bucket_downloader): add S3 bucket downloader tool#13
Merged
sangshuduo merged 2 commits intomainfrom Apr 1, 2025
Merged
feat(s3_bucket_downloader): add S3 bucket downloader tool#13sangshuduo merged 2 commits intomainfrom
sangshuduo merged 2 commits intomainfrom
Conversation
- Implemented a new tool to download files from an S3 bucket using multiple threads. - Added command-line arguments for bucket name, output directory, number of workers, and retries. - Included a feature to read file lists from a specified file or list objects directly from the bucket. - Utilized libraries such as `aws-sdk-s3` and `tokio` for asynchronous operations.
Contributor
|
I'm getting to work. See my steps and track my cost here.
|
Contributor
|
I've taken a look at your S3 bucket downloader implementation. This looks like a great addition to the toolkit that complements the existing A few thoughts: Strengths:
Potential improvements:
Let's see what the CI says, but this looks like a solid implementation to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-sdk-s3andtokiofor asynchronous operations.