fix(s3_bucket_downloader): add redownload mode for missing files#14
Merged
sangshuduo merged 1 commit intomainfrom Apr 2, 2025
Merged
fix(s3_bucket_downloader): add redownload mode for missing files#14sangshuduo merged 1 commit intomainfrom
sangshuduo merged 1 commit intomainfrom
Conversation
Owner
sangshuduo
commented
Apr 2, 2025
- Introduced a new redownload mode to check existing files and only download missing ones.
- Added a command-line argument to enable this feature.
- Updated progress reporting to reflect the number of existing and missing files.
- Introduced a new redownload mode to check existing files and only download missing ones. - Added a command-line argument to enable this feature. - Updated progress reporting to reflect the number of existing and missing files.
Contributor
|
I'm getting to work. See my steps and track my cost here.
|
Contributor
There was a problem hiding this comment.
I've reviewed this PR and the implementation looks good! The redownload mode is a useful feature that will help save bandwidth and time by only downloading missing files.
Some notes on the implementation:
- The command-line argument is properly added with good documentation
- The file existence checking logic is clear and straightforward
- The progress reporting is updated appropriately to show existing vs. missing file counts
- The early return when no files need downloading is a good optimization
The code maintains the existing behavior when redownload mode is not enabled, which is great.
One small suggestion: the thread progress message changed from showing detailed counts to a simpler "by Thread X" message. This seems less informative than before, but it's a minor UI detail.
Overall, this is a well-implemented feature that adds useful functionality. Approving!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.