Fix SD read in CRC calculation #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very rare cases, the CRC calculation becomes incorrect even though the ROM file itself is generated correctly, and the CRC value differs on each run.
The suspected cause is that read() may return -1 at end-of-file, but the return value is stored in a uint32_t. As a result, the loop condition evaluates as true and the CRC is updated unintentionally.
With this change, the issue no longer occurs in my environment. I also verified that normal CRC calculations are unaffected.
This issue is extremely difficult to reproduce, but I would appreciate it if you could review it when you have time.