Open
Conversation
wagnerd3
force-pushed
the
soft_delete_commitments
branch
from
ba99ed4 to
61091a2
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| if slices.Contains([]liquid.CommitmentStatus{liquid.CommitmentStatusSuperseded, liquid.CommitmentStatusExpired}, dbCommitment.Status) { | ||
| http.Error(w, "expired or superseded commitments cannot be transferred", http.StatusBadRequest) | ||
| if slices.Contains([]liquid.CommitmentStatus{liquid.CommitmentStatusSuperseded, liquid.CommitmentStatusExpired, util.CommitmentStatusDeleted}, dbCommitment.Status) { | ||
| http.Error(w, "expired, superseded and deleted commitments cannot be transferred", http.StatusBadRequest) |
Member
There was a problem hiding this comment.
Suggested change
| http.Error(w, "expired, superseded and deleted commitments cannot be transferred", http.StatusBadRequest) | |
| http.Error(w, "expired, superseded or deleted commitments cannot be transferred", http.StatusBadRequest) |
|
|
||
| // This query updates `project_commitments.status` on all rows that have not | ||
| // reached one of the final statuses ("superseded" and "expired"). | ||
| // reached one of the final statuses ("superseded", "expired" and "deleted"). |
Member
There was a problem hiding this comment.
Suggested change
| // reached one of the final statuses ("superseded", "expired" and "deleted"). | |
| // reached one of the final statuses ("superseded", "expired" or "deleted"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For debugging purposes, it is a little tedious to understand effects which involve hard-deletions of commitments. Therefore, we are introducing a soft-deletion + hard-deletion after grace period of 6 months (TBD).
Also, this aids future development in direction of an advanced billing process because we might need to consider deletion events of commitments with their specific timestamp (
deleted_at).