-
Notifications
You must be signed in to change notification settings - Fork 36
ADD: bad_by_PSD method #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Randomidous
wants to merge
35
commits into
sappelhoff:main
Choose a base branch
from
Randomidous:PSD-inc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b5d9f5f
ADD prototype of bad_by_PSD() method
nabilalibou 2ce9ac1
fix bad_by_PSD
Randomidous f5c1f8a
avoid 50Hz
Randomidous 72ae6f8
add test for bad_by_PSD
Randomidous fc9d3ab
update matlab diffs
Randomidous eff0a71
add self as author
Randomidous 157506f
update changelog
Randomidous 65de129
add to authors
Randomidous 9e0f168
ADD: reject_by_annotation to NoisyChannels
Randomidous b273289
add to reference
Randomidous d1443a2
add to pipeline
Randomidous d75739d
add test
Randomidous f687b51
change ', optional' to ' | None' for consistency
Randomidous 3b29440
self.add_creds(me)
Randomidous 1e2fb2f
update change log
Randomidous 3768232
update matlab diffs
Randomidous 6bc4c76
Add author to change log
Randomidous 5a4597d
split spectrum into three bands; add additional criteria
Randomidous c1519a9
update tests
Randomidous 80effa5
refine matlab diff details
Randomidous 8c25932
find bad by PSD by default
Randomidous 7a04d83
don't use ratio criterion
Randomidous 26c82d8
add to noisy dict; should fix tests
Randomidous c4fa6c8
only consider positive z-scores
Randomidous 1292494
update test to reflect changed criterion
Randomidous fca0155
booted superfluous test (yeet)
Randomidous 8d0c792
Update docs/matlab_differences.rst
Randomidous b9a86a9
Merge branch 'break-it-down-for-me' of https://github.com/Randomidous…
Randomidous 7d0da63
warn when matlab strict AND reject segments
Randomidous d0af09e
xref for info on bad segment marking
Randomidous d85d0b3
add warning when a lot (>10%) of data is marked bad
Randomidous 59bee0f
make that 15%
Randomidous 9fc0f9e
saying na-na-na to NaNs
Randomidous c01217e
NaN shall pass
Randomidous 948a698
Merge PSD-inc and break-it-down-for-me for testing
Randomidous File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule matprep_artifacts
updated
3 files
| +11 −17 | .github/workflows/build_artifacts.yml | |
| +0 −7 | LICENSE | |
| +27 −25 | config/pipeline_setup.py |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.