Open
Conversation
- pd10143: Enforce unique state variables per EPN (Spec 3.5.1.1) - pd10144: Limit catalysis arcs to one per process (Spec 3.5.2.4.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements two validation rules that were specified in the SBGN Process Description (PD) Level 1 Version 2.0 specification but were missing from the existing
sbgn_pd.schSchematron rules.New rules added:
Detailed Changes
Rule: Unique State Variables per EPN (pd10143)
Spec Reference: Section 3.5.1, Rule 1
Implementation:
Checks that the count of state variables equals the count of distinct state variables within a stateful EPN.
Example Violation:
Rule: At Most One Catalysis Per Process (pd10144)
Spec Reference: Section 3.5.2.4, Rule 8
Implementation:
Checks that the number of catalysis arcs targeting a specific process (or its ports) is less than or equal to 1.
Example Violation:
Verification
I verified these changes by creating specific test files containing these violations and running the Ant validation target (
ant schematron-validate-dir).Test Results:
pd10143.state-count - 2,unique-count - 1pd10144.catalysis-count - 2Existing tests passed successfully.