This repository was archived by the owner on Jan 17, 2022. It is now read-only.
Export header size #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Nov 22, 2016
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Same as the other PR, lacks the associated documentation. Also, there is no tests.
|
|
||
| uint32_t header_size = sizeof(fragment_header_t); | ||
| info.GetReturnValue().Set(header_size); | ||
| } |
| } | ||
| }, | ||
|
|
||
| getHeaderSize: function() { |
lamphamsy
force-pushed
the
ft/export_header_size
branch
from
ad4d2e7 to
2227740
Compare
lamphamsy
force-pushed
the
ft/export_header_size
branch
from
2227740 to
6aa94ba
Compare
Contributor
Author
|
The PR is too small and too clear for test. I think test is useful only for #45 |
Contributor
Author
|
updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get fragment's header size