fix: Fix offset reset issue caused by floating-point precision at boundary positions #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndary positions When the panel is already at a boundary position, floating-point precision errors on some devices can cause unexpected offset resets in the position calculation. By applying floor() to the position calculations for top, left, bottom, and right edges in FloatingPanelLayoutAnchor, we ensure integer values are returned, preventing layout issues caused by floating-point precision errors.
0x1306a94
force-pushed
the
fixbug/scroll_lock
branch
from
8899093 to
7971502
Compare
Author
|
The code implementation plan has been adjusted and fixed, and all local unit tests have passed. 2026-01-13.16.48.33_compressed.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the panel is already at a boundary position, floating-point precision errors on some devices can cause unexpected offset resets in the position calculation.
By applying floor() to the position calculations for top, left, bottom, and right edges in FloatingPanelLayoutAnchor, we ensure integer values are returned, preventing layout issues caused by floating-point precision errors.
#626
FloatingPanelSample.zip
2026-01-13.09.56.34_compressed.mp4