three seconds is better #1558
Open
three seconds is better #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR increases the LED on-time delay from 1 second to 3 seconds to make the LED blink more noticeable.
- Changed the
delay()value from 1000ms to 3000ms for the LED on-state
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
23
| delay(3000); // wait for a second | ||
| digitalWrite(led, LOW); // turn the LED off by making the voltage LOW | ||
| delay(2000); // wait for a second |
There was a problem hiding this comment.
The comment states "wait for a second" but the delay is now 3000 milliseconds, which is 3 seconds. The comment should be updated to accurately reflect the actual delay duration.
Suggested change
| delay(3000); // wait for a second | |
| digitalWrite(led, LOW); // turn the LED off by making the voltage LOW | |
| delay(2000); // wait for a second | |
| delay(3000); // wait for three seconds | |
| digitalWrite(led, LOW); // turn the LED off by making the voltage LOW | |
| delay(2000); // wait for two seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the LED delay from 1 second to 3 seconds to make it more noticeable.