Skip to content

Conversation

@Artimi
Copy link

@Artimi Artimi commented Dec 12, 2016

cystatsd does not have to depend on cython for user. If we include generated file cystatsd/collector/collector.cpp we can ship cystatsd without cython. However, if user has cython installed it will be used to regenerate that file. You can find information about this in http://stackoverflow.com/questions/4505747/how-should-i-structure-a-python-package-that-contains-cython-code . This is even recommended by cython itself http://docs.cython.org/en/latest/src/reference/compilation.html#distributing-cython-modules . You won't to regenerate that file when something changes because I edited implementation of sdist so the file is regenerated each time sdist is called and something in source files changed.

@Artimi Artimi force-pushed the feature/optional-cython branch from 4b4286f to 61b74a5 Compare December 13, 2016 14:23
@scivey
Copy link
Owner

scivey commented Dec 24, 2016

Looks solid, thanks for the PR! Going to test this out before merging, so may be a couple more days before this gets to PyPI.

@vitawasalreadytaken
Copy link

Hi @scivey, have you had time to test this? We're looking forward to releasing a fast statsd client based on cystatsd and this is hopefully our last blocker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants