Feature/float metrics #3
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for float metrics
Statsd server supports gauges and timers to contains float values.
Why
Implementation
Implementation is done by:
FloatMetricwhich holds a float value.Metric::encodeToto new virtual methodMetric::formatValueFloatMetric::formatValueSampledMetric::metric_.- This is changing
SampledMetric::metric_to a pointer.- Then a destructor for
SampledMetricis implemented and copy constructors for:Metric,FloatMetricandSampledMetricWhich metric is being used is decided by constructor overloading.
Conclusion
Implementation using templates in C++ part would be much nicer, but it would introduce more pointers and dynamic memory allocation, which i tried to avoid.
This solution uses only one pointer which is created in constructor of
SampledMetricand then removed in it's destructor so it is still easily manageable and it follow RAII.