Fix bug when ordering elements on queue when get next batch of requests#352
Open
jpbalarini wants to merge 2 commits intoscrapinghub:masterfrom
Open
Fix bug when ordering elements on queue when get next batch of requests#352jpbalarini wants to merge 2 commits intoscrapinghub:masterfrom
jpbalarini wants to merge 2 commits intoscrapinghub:masterfrom
Conversation
Contributor
|
Great! Thanks for this fix! |
Author
|
@sibiryakov what do you think of this? Can we merge it? |
Member
|
hey @jpbalarini thanks for the contribution, will try to respond quicker next time. It seems this wasn't covered with the test, can you add them? |
Author
|
@sibiryakov done! added tests for the SQL alchemy Thanks! |
Author
|
Hi @sibiryakov I added the tests and everything as requested some time ago. |
|
When this fix will be applied? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when using a MySQL database as backend the
queuetable was being consumed in the opposite order as intended (elements with lower priority were being consumed first).I found that on the
queuecomponent the_order_bymethod had no default order condition, so I added an explicitdesc()clause (elements with bigger priority first). I guess this can apply to other backends (Postgres).Thanks!