-
Notifications
You must be signed in to change notification settings - Fork 103
Feature/colon to emoji toggle #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/colon to emoji toggle #579
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-iOS repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Thanks for opening a PR here, @jatinfoujdar! I'll take a look to see how this is working :) |
|
Hey @jatinfoujdar 👋 I'm taking a quick look at this, but I can't seem to get the |
|
Hey @andrewtavis! 👋 I looked into why you might not have been seeing the emoji suggestions. It turns out there was a bug where the 'colon to emoji' feature (and a few other settings) were defaulting to false in UserDefaults if they hadn't been explicitly toggled in the app's settings yet. I've just pushed a fix that ensures these features default to true, matching the intended behavior and the Settings UI. To use it, simply type a : followed by a keyword (e.g., :smile) on any Scribe keyboard, and you should see the emoji suggestions appear in the top bar. Typing just the : should also immediately show the most common emojis. Let me know if it works for you now! If you'd still like a video, I'd be happy to record one from the simulator. Thanks! |
|
Thanks for the quick fix, @jatinfoujdar! I think I'm generally seeing what's intended here :) I guess now that I'm seeing it, there is an improvement upon the already existing emoji autosuggestion functionality, but maybe we can do more? 🤔 The Maybe something that could be done is we could expand the emoji fields to be six if the user types Another thing that I'm seeing is that there's a background behind the autosuggestions if the user has types
Could we look into fixing the above, and from there it'd be great to get your feedback on the idea of expanding the number of emojis. I just think that the way that it is now, we're still showing autosuggested words and the UI looks a bit awkward. We could expand the number of emojis per word with Scribe-Data and then provide a full row of emojis that are updating as the user types :) |
|
@andrewtavis Thanks for the detailed feedback — I agree 🙂 The : entry is an improvement, but it’s still constrained by the word autosuggestion layout, which makes the UI feel a bit awkward right now. I’ll look into fixing the autosuggestion background when typing : and hiding word suggestions when we’re clearly in emoji mode. I also like the idea of expanding emoji suggestions to a full row (5–6) when : is active. That would likely require regenerating data in Scribe-Data and some layout changes, so it’ll take a bit of time to do properly, but it feels like the right direction. Thanks again — happy to iterate on this 👍 |
|
Great to get your thoughts on this, @jatinfoujdar! Let's maybe start with the minor fixes to this PR so that we don't have the backgrounds being added to the suggestions. From there we can look into:
Really looking forward to seeing how this progresses! Thanks for your efforts so far! 😊 |
|
Hi @andrewtavis Thanks for the guidance! I’ve implemented the minor fix to clean up the emoji suggestion UI in this PR — backgrounds are no longer applied to emoji suggestions. |
|
Great to see the progress here, @jatinfoujdar! Will be great to be able to bring this in :) |

Contributor checklist
xcodebuildandswiftlint --strictcommandsDescription
This PR adds a new "Colon to emoji entry" toggle to the keyboard settings. When enabled, users can type a colon (:) followed by a keyword to get emoji suggestions, similar to Slack or Discord. If the toggle is off, this feature is disabled.
Main changes:
Related issue
:to emoji entry command for Scribe keyboards #364