Add Root Prover #1193
Open
Add Root Prover #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darth-cy
force-pushed
the
feat/root_prover_verifier
branch
from
3f144d8 to
de74651
Compare
kunxian-xia
reviewed
Dec 15, 2025
- Restructure the public values in recursion - Aggregate and check septic point summation in the aggregation tree
kunxian-xia
reviewed
Dec 19, 2025
| // } | ||
| Ok(app_commit) | ||
| } | ||
| // pub fn verify_e2e_stark_proof( |
Collaborator
There was a problem hiding this comment.
This is commented out.
Collaborator
Author
There was a problem hiding this comment.
This is the verifier for the last internal proof (in OpenVM, it's called e2e_stark_proof) and should actually be deleted. Since the aggregation now outputs the root proof, the correct verifier is generated here: https://github.com/scroll-tech/openvm/blob/main/crates/sdk/src/lib.rs#L280-L296
hero78119
requested changes
Dec 23, 2025
Collaborator
hero78119
left a comment
hero78119
left a comment
There was a problem hiding this comment.
Try new api in this PR on https://github.com/scroll-tech/ceno-reth-benchmark e2e, need to adjust further of new api design
hero78119
force-pushed
the
feat/root_prover_verifier
branch
from
c5f9590 to
bb3eb54
Compare
hero78119
reviewed
Dec 24, 2025
Collaborator
hero78119
left a comment
hero78119
left a comment
There was a problem hiding this comment.
Reported with e2e test with block 23587691
- e2e prove/verify pass
- final root proof size: 671K
- currently only cpu mode, as I didn't find respective gpu config for root prover. On cpu root proof take
89.78s. We need a way to switch to gpu config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.