cleanup complex padding logic in local-finalize-circuit #1202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously in first shard to balance r/w consistent for heap/stack, local finalize circuit implement complex logic to absorb those padding but no read logic into read set.
Since right now table circuit also relax the limitation and num_instances doesn't need to be power of 2. We can change selector from
wholetoprefix, exclude padding zero into localwrite set, so we can clean up local finalized circuitread setpadding logictesting
e2e verified in proving
23587691.