Conversation
|
Hi @Tobiaspk, thanks for submitting your package! I have a couple of comments:
While you do have versioned releases on PyPI, please also tag them on GitHub and/or make releases using the GitHub release feature.
The tests look mostly good, but the functions seem to only test that the model can be run and some general assertions. I was wondering if it would be possible to also test for correctness, e.g. by running the model on a small test dataset and compare against a snapshot of the results? That way you would at least be alerted if something changes.
By API documentation, we mean an overview of all user-facing functions/classes and documentation of their parameters. While you porvide this for While it's possible to do this manually in the README, I'd recommend checking out the sphinx autodocs module. Here's an example of it in action. And you can check out our cookiecutter for a spinx setup. Other comments:
|
|
Hi Gregor, thanks for your review and feedback. We'll update both packages as soon as possible, will reach out when done! |
Name of the tool: Spectra
Short description: Spectra is a supervised factor analysis method that fits a seeded matrix factorization using either gene sets or a graph.
How does the package use scverse data structures (please describe in a few sentences): All main operations, such as gene selection, filters etc. are based on adata structures.