(improvement) remove query to TRIGGERS (which do not exist in ScyllaDB) #629
+10
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With CoPilot, I removed the query, since this functionality doesn't exist in ScyllaDB at all. Refs: scylladb#453 Refs: https://scylladb.atlassian.net/browse/CUSTOMER-62 Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
Author
|
CI failures do not seem related to this patch :-/ |
Lorak-mmk
requested changes
Dec 29, 2025
Lorak-mmk
left a comment
Lorak-mmk
left a comment
There was a problem hiding this comment.
Can you try to run integration tests with Cassandra and see if there are new failures caused by this change?
We do not currently do this in CI, there was work to do this but it was not finished: #339
Let's not make things more difficult for someone picking it up again.
Did you consider using those queries only with Cassandra, instead of removing them completely?
| indexes_result = self._handle_results(indexes_sucess, indexes_result, query_msg=indexes_query) | ||
| triggers_result = self._handle_results(triggers_success, triggers_result, query_msg=triggers_query) | ||
| return self._build_table_metadata(table_result[0], col_result, triggers_result, indexes_result) | ||
| return self._build_table_metadata(table_result[0], col_result, None, indexes_result) |
There was a problem hiding this comment.
Instead of passing None can you remove the argument from _build_table_metadata? Let's not introduce dead code.
| table_name = row[self._table_name_col] | ||
|
|
||
| col_rows = col_rows or self.keyspace_table_col_rows[keyspace_name][table_name] | ||
| trigger_rows = trigger_rows or self.keyspace_table_trigger_rows[keyspace_name][table_name] |
There was a problem hiding this comment.
Did you remove self.keyspace_table_trigger_rows as well?
Comment on lines
-2698
to
-2701
| for trigger_row in trigger_rows: | ||
| trigger_meta = self._build_trigger_metadata(table_meta, trigger_row) | ||
| table_meta.triggers[trigger_meta.name] = trigger_meta | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CoPilot, I removed the query, since this functionality doesn't exist in ScyllaDB at all.
Refs: #453
Refs: https://scylladb.atlassian.net/browse/CUSTOMER-62
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.