Open
Conversation
Collaborator
Author
|
after discussions with @ppdewolf this should not yet be merged yet in order to retain consistency between results from sdcMicro / muargus. |
|
Thanks!
Van: bernhard-da ***@***.***>
Verzonden: vrijdag 22 juli 2022 07:53
Aan: sdcTools/sdcMicro ***@***.***>
CC: Peter-Paul de Wolf ***@***.***>; Mention ***@***.***>
Onderwerp: [*Nieuwsbrief*] [*Mail werd niet vanaf de juiste machine verstuurd*] Re: [sdcTools/sdcMicro] Feature carryalong checks (PR #322)
after discussions with @ppdewolf<https://github.com/ppdewolf> this should not yet be merged yet in order to retain consistency between results from sdcMicro / muargus.
—
Reply to this email directly, view it on GitHub<#322 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEWQ4QZCCPGEGTRPAGIWEU3VVIZKRANCNFSM54GQCDZA>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds a check to the recordSwapping library related to
carry_alongvariables; it is checked that variables specified ascarry_alongvariables are at household-level which means that there is only a single value within each household-id; a corresponding unit-test has been added and additionally a minor issue in utility-functioncreateDat()that samples test-input data for the record swapping procedure was fixed;