Make it work with Inkscape 1.3 #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulugithub
reviewed
Feb 9, 2025
| # Convert PDF to SVG | ||
| if PLATFORM == WINDOWS: | ||
| PDF2SVG_PATH = os.path.join(os.path.realpath(EXT_PATH), 'pdf2svg') | ||
| if PLATFORM == MAC: |
There was a problem hiding this comment.
if has to be replaced by elif, otherwise the code on Windows will result in empty PDF2SVG_PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and perhaps other versions of Inkscape; I've only tested against 1.3.2.)
This removes Python and PyGTK deprecation warnings and gets the extension ready to work with changes to the manifest format. It also pulls in fixes from seignovert/LaTeXText.