Open
Conversation
🦋 Changeset detectedLatest commit: 3b054bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Generally i love this idea and its been something we wanted to look at. I am curious about the issues with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is just me playing around and poking the bear to see if you're interested in this.
Currently, playroom ships the entire src directory as-is, meaning that the job of compiling playrooms internal components and styles, etc falls to the user. This also means that there are quite a few dependencies included just because of this, mainly a bunch of Vanilla Extract related deps.
What if playroom would prebundle its source code, compiling out the TypeScript and Vanilla Extract code, and leaving just normal CSS/JS to be imported by webpack?
This cleans up a bunch of code and deps - they can be devDeps now. Maybe some more can be move, e.g. some of the
@types/*packages? The webpack config is quite complex, I'm not exactly sure how much of that was just needed to compile src previously.Note: the src is bundled with vite library mode instead of tsdown as I ran into some weird issues with tsdown - but maybe we can figure out some solution if you think using vite for build is not the best idea.