[MP-1010] Fix ampersand in email_subject_room_name#12
Open
dasha140132 wants to merge 1 commit intosa_patches_3.6.0from
Open
[MP-1010] Fix ampersand in email_subject_room_name#12dasha140132 wants to merge 1 commit intosa_patches_3.6.0from
dasha140132 wants to merge 1 commit intosa_patches_3.6.0from
Conversation
dasha140132
force-pushed
the
mp_1010_fix_ampersands_in_email_subject_room_name
branch
2 times, most recently
from
66305f1 to
5860f15
Compare
dasha140132
force-pushed
the
mp_1010_fix_ampersands_in_email_subject_room_name
branch
from
5860f15 to
e4c4b1c
Compare
nmagedman
requested changes
Oct 25, 2020
nmagedman
left a comment
nmagedman
left a comment
There was a problem hiding this comment.
Thank you, but this doesn't feel like it's the right approach. We have a mixing of concerns (both in upstream's code and in this patch) where replacekey (and by extension replace) is doing two unrelated things:
- It is expanding placeholders in a template string.
- It is HTML-escaping the template values.
I prefer that we separate these concerns. replace/replacekeys should only do text substitution. The caller should handle any escaping before passing in data/value. If needed, we can have another helper function that escapes all the values in an object, which we could compose with replace().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.