[AR-2515] Change searching username/email from case-insensitive regex to collation#15
Open
kapcod wants to merge 1 commit intosa_patches_3.17.0-sa.5__reinstate_patch___Remove_header_X-Content-Type-Options_nosnifffrom
Conversation
Case insensitive regex cannot leverage index, collation search, however can leverage respective collation index and so instead of fullscan this query will find the user immediately generateUsernameSuggestion: previously it tried to reduce number of iterations by checking how many nicks were already created like this. However, this search has to do fulltable scan, while a single username search is efficient, so better to always iterate from 1. Thought for the future, maybe it's better to just do random of 1000 instead of consecutive number.
kapcod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case insensitive regex cannot leverage index, collation search, however can leverage respective collation index and so instead of fullscan this query will find the user immediately
generateUsernameSuggestion: previously it tried to reduce number of iterations by checking how many nicks were already created like this. However, this search has to do fulltable scan, while a single username search is efficient, so better to always iterate from 1. Thought for the future, maybe it's better to just do random of 1000 instead of consecutive number.